fix(discovery): support NestJS 11 #945
Merged
underfisk merged 3 commits intogolevelup:masterfrom Jan 22, 2025
xballoy:fix/944-nestjs-11-support
Merged
fix(discovery): support NestJS 11 #945underfisk merged 3 commits intogolevelup:masterfrom xballoy:fix/944-nestjs-11-support
underfisk merged 3 commits intogolevelup:masterfrom
xballoy:fix/944-nestjs-11-support
Conversation
From NestJS 11, InstanceWrapper.metatype can be null. Mapping it from `null` to `undefined` for `DiscoveredClass.injectType` to avoid a breaking change. #944
Contributor
Author
|
I successfully locally run I did not run the |
underfisk
reviewed
Jan 22, 2025
Collaborator
@xballoy Not an issue, CI will run those checks for you. |
Support both undefined and null while supporting NestJS 10 and 11.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #937 to support NestJS 11.
Starting version 11,
InstanceWrapper.injectcan benull(see v11 vs v10).In order to prevent a breaking change in discovery by respecting the
DiscoveredClasstype we mapnulltoundefined.Fixes #944