Skip to content

Conversation

@mniestroj
Copy link
Collaborator

Tinycrypt is no longer needed, as there was a switch to other crypto
implementation.

@github-actions
Copy link

github-actions bot commented Jan 29, 2025

Visit the preview URL for this PR (updated for commit fdd60c0):

https://golioth-firmware-sdk-doxygen-dev--pr740-drop-tinycrypt-952yqhcz.web.app

(expires Wed, 23 Apr 2025 17:13:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a9993e61697a3983f3479e468bcb0b616f9a0578

@mniestroj mniestroj marked this pull request as draft January 29, 2025 18:46
@github-actions
Copy link

github-actions bot commented Jan 29, 2025

Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
include.golioth 75% 50%
port.linux 62% 34%
port.utils 58% 46%
port.zephyr 53% 22%
src 70% 32%
Summary 69% (2852 / 4161) 31% (1189 / 3778)

@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 3 files with indirect coverage changes

@mniestroj mniestroj force-pushed the drop-tinycrypt branch 2 times, most recently from 4d3ae44 to 9204326 Compare March 18, 2025 14:23
Tinycrypt is no longer needed, as there was a switch to other crypto
implementation.

Signed-off-by: Marcin Niestroj <m.niestroj@emb.dev>
@mniestroj mniestroj changed the title west: drop 'tinycrypt' module west-zephyr: drop 'tinycrypt' module Apr 17, 2025
@mniestroj mniestroj marked this pull request as ready for review April 17, 2025 08:03
@mniestroj
Copy link
Collaborator Author

Dropped tinycrypt only from west-zephyr variant, as for west-ncs we still need it due to older version of Zephyr used.

For NCS tinycrypt will be dropped as part of #753.

@mniestroj mniestroj requested review from sam-golioth and szczys April 17, 2025 08:05
@mniestroj mniestroj merged commit 9c2d4d6 into main Apr 22, 2025
131 of 140 checks passed
@mniestroj mniestroj deleted the drop-tinycrypt branch April 22, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants