Skip to content

Add Modbus Vibration Monitor reference design #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add Modbus Vibration Monitor reference design #2

merged 1 commit into from
Feb 19, 2024

Conversation

@cdwilson
Copy link
Collaborator

@cdwilson cdwilson commented Jan 19, 2024 •
edited
Loading

Initial version of the modbus vibration monitor reference design firmware.

Release testing

aludel_mini_v1_sparkfun9160_ns

  • Shell/Credentials
  • Connection
  • Logs
  • State
  • Stream
  • Button press
  • Settings (Loop Delay)
  • RPC (log level)
  • RPC(network info)
  • RPC(reboot)
  • Battery level
  • Ostentus
  • OTA Update

nrf9160dk_nrf9160_ns

  • Shell/Credentials
  • Connection
  • Logs
  • State
  • Stream
  • Button press
  • Settings (Loop Delay)
  • RPC (log level)
  • RPC(network info)
  • RPC(reboot)
  • OTA Update

aludel_elixir_v1_ns

  • Shell/Credentials
  • Connection
  • Logs
  • State
  • Stream
  • Button press
  • Settings (Loop Delay)
  • RPC (log level)
  • RPC(network info)
  • RPC(reboot)
  • Ostentus
  • OTA Update

@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch from 53d7d92 to 26fb3b6 Compare January 21, 2024 02:13
@cdwilson cdwilson deleted the branch main January 21, 2024 02:28
@cdwilson cdwilson closed this Jan 21, 2024
@cdwilson cdwilson reopened this Jan 21, 2024
@cdwilson cdwilson changed the base branch from cdwilson/merge-changes-from-template to main January 21, 2024 02:51
@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch 4 times, most recently from 9abc87c to e8411a8 Compare January 26, 2024 07:51
@cdwilson cdwilson marked this pull request as ready for review January 26, 2024 07:57
@cdwilson cdwilson changed the title [WIP] Add Modbus Vibration Monitor reference design Add Modbus Vibration Monitor reference design Jan 26, 2024
@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch 2 times, most recently from 4f16327 to 446a5af Compare January 26, 2024 08:54
@cdwilson cdwilson self-assigned this Jan 26, 2024
@cdwilson cdwilson added the enhancement New feature or request label Jan 26, 2024
@cdwilson cdwilson requested review from MarkoPura and szczys January 26, 2024 09:03
@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch 2 times, most recently from 116bb59 to b053174 Compare February 7, 2024 00:36
@ChrisGammell ChrisGammell self-requested a review February 13, 2024 19:15
ChrisGammell
ChrisGammell reviewed Feb 13, 2024
View reviewed changes
szczys
szczys reviewed Feb 15, 2024
View reviewed changes
cdwilson
cdwilson commented Feb 16, 2024
View reviewed changes
Copy link
Collaborator Author

@cdwilson cdwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@szczys thanks for the review!

@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch from b053174 to e55d4c7 Compare February 16, 2024 00:28
@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch 3 times, most recently from 1159707 to 914a3ef Compare February 16, 2024 14:41
@szczys szczys mentioned this pull request Feb 16, 2024
Open
@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch from 914a3ef to 856201f Compare February 16, 2024 17:39
cdwilson
cdwilson commented Feb 16, 2024
View reviewed changes
szczys
szczys approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@szczys szczys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all your work on this!

@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch 2 times, most recently from 92eacb9 to ddd3734 Compare February 19, 2024 15:17
@cdwilson
Add Modbus Vibration Monitor reference design
3ccfdb5 
Signed-off-by: Chris Wilson <chris@cgnd.dev>
@cdwilson cdwilson force-pushed the cdwilson/modbus-vibration-monitor branch from ddd3734 to 3ccfdb5 Compare February 19, 2024 17:46
@cdwilson cdwilson merged commit 566bddc into main Feb 19, 2024
@cdwilson cdwilson deleted the cdwilson/modbus-vibration-monitor branch February 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisGammell ChrisGammell ChrisGammell left review comments

@szczys szczys szczys approved these changes

+1 more reviewer

@MarkoPura MarkoPura MarkoPura approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cdwilson cdwilson

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cdwilson @szczys @ChrisGammell @MarkoPura