move go.mod to v2 #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicerobot
reviewed
May 8, 2021
Member
nicerobot
left a comment
nicerobot
left a comment
There was a problem hiding this comment.
Thanks. I'll take a look a little later today.
nicerobot
approved these changes
May 9, 2021
Contributor
Author
|
Hi, @nicerobot, I missed one point: You'll have to do a new tag maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of go will ignore v2.x.x tags unless it is explicit in the
go.modgo get github.com/gomatic/renderizer/cmd/renderizercurrently default tov1.0.1and the file structure is different on that version so the get will fail.With this patch
go get github.com/gomatic/renderizer/v2/cmd/renderizershould work as expected.