Skip to content

fix(edgedelta): use native Makeself extraction instead of fragile shell-carving#296

Closed
edge-delta[bot] wants to merge 3 commits into
mainfrom
fix/edgedelta-makeself-extraction
Closed

fix(edgedelta): use native Makeself extraction instead of fragile shell-carving#296
edge-delta[bot] wants to merge 3 commits into
mainfrom
fix/edgedelta-makeself-extraction

Conversation

@edge-delta

@edge-delta edge-delta Bot commented Jun 25, 2026

Copy link
Copy Markdown

Summary

This PR replaces the fragile manual carving of the Makeself archive payload in packages/edgedelta/build.sh with the installer's native --target payload --noexec extraction mechanism.

Related issues

Ref: #295

Changes

  • Replaced fragile grep, head, and tail byte offset calculation in packages/edgedelta/build.sh with sh "$installer" --target payload --noexec.

Checklist

  • I've read CONTRIBUTING.md.
  • I've accepted the ICLA (and CCLA if contributing on my employer's time). CLA Assistant will prompt me on this PR if I haven't already.
  • min check passes for the affected packages/harnesses.
  • min patched-build <name> succeeds for any package I added or modified.
  • For new packages: source_provenance points to the canonical upstream and the source builds from source (not a prebuilt release binary) where the required toolchain is available.
  • For version bumps: I've verified the new sha256 against the upstream archive.

Notes for reviewers

The native --target payload --noexec options are standard across Makeself installers, making extraction highly robust against upstream changes to the header layout or tool environment differences.


This pull/merge request was created by Edge Delta AI Teammates — see #code-issues for the original conversation.

jtnkminimal and others added 2 commits June 25, 2026 10:10
Packages the Edge Delta observability agent (v2.19.0) by extracting the
binary from upstream's Makeself self-extracting installer, skipping the
installer's host-mutating steps (user creation, service install, agent
start). amd64 and arm64 supported; ca-certificates as a runtime dep for TLS.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Edge Delta AI Teammates seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@bryan-minimal

Copy link
Copy Markdown
Member

Thanks so much for this, and for digging into our packaging — the hand-rolled Makeself byte-carving in the edgedelta package is genuinely fragile; the installer's native --target payload --noexec is the right call. 🙏

We're closing this in favour of small, focused internal fixes: we've distilled it, along with your other PRs, into #353, which tracks the underlying findings as actionable items. This PR bundled a number of unrelated package changes and overlapped with others, and we keep changes small and focused per CONTRIBUTING — but the insight is captured and we'll land the fix on our side.

Genuinely grateful for the contribution — please don't let this discourage smaller, focused follow-ups. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants