fix(edgedelta): use native Makeself extraction instead of fragile shell-carving#296
fix(edgedelta): use native Makeself extraction instead of fragile shell-carving#296edge-delta[bot] wants to merge 3 commits into
Conversation
Packages the Edge Delta observability agent (v2.19.0) by extracting the binary from upstream's Makeself self-extracting installer, skipping the installer's host-mutating steps (user creation, service install, agent start). amd64 and arm64 supported; ca-certificates as a runtime dep for TLS. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Edge Delta AI Teammates seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Thanks so much for this, and for digging into our packaging — the hand-rolled Makeself byte-carving in the edgedelta package is genuinely fragile; the installer's native --target payload --noexec is the right call. 🙏 We're closing this in favour of small, focused internal fixes: we've distilled it, along with your other PRs, into #353, which tracks the underlying findings as actionable items. This PR bundled a number of unrelated package changes and overlapped with others, and we keep changes small and focused per CONTRIBUTING — but the insight is captured and we'll land the fix on our side. Genuinely grateful for the contribution — please don't let this discourage smaller, focused follow-ups. 🙏 |
Summary
This PR replaces the fragile manual carving of the Makeself archive payload in
packages/edgedelta/build.shwith the installer's native--target payload --noexecextraction mechanism.Related issues
Ref: #295
Changes
packages/edgedelta/build.shwithsh "$installer" --target payload --noexec.Checklist
min checkpasses for the affected packages/harnesses.min patched-build <name>succeeds for any package I added or modified.source_provenancepoints to the canonical upstream and the source builds from source (not a prebuilt release binary) where the required toolchain is available.sha256against the upstream archive.Notes for reviewers
The native
--target payload --noexecoptions are standard across Makeself installers, making extraction highly robust against upstream changes to the header layout or tool environment differences.This pull/merge request was created by Edge Delta AI Teammates — see #code-issues for the original conversation.