Add DialURL to allow connection using a Redis URL - #145
Merged
2 commits merged intoSep 1, 2015
Merged
Conversation
shosti
force-pushed
the
url-dialer
branch
4 times, most recently
from
August 31, 2015 07:59
e649a80 to
5384e59
Compare
Contributor
Author
|
OK, I updated the pull request. Unfortunately, I don't think there's any way to check which database is selected without writing to the database (correct me if I'm wrong), so I just added a check to make sure that DBSIZE is 0. Let me know if you notice anything else. |
shosti
force-pushed
the
url-dialer
branch
2 times, most recently
from
August 31, 2015 08:11
0d15364 to
5e9d3af
Compare
ghost
mentioned this pull request
ghost
locked and limited conversation to collaborators
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After thinking about it some more, I think it's cleaner to take a URL
object instead of an unparsed string, but I think either way would work.