Fixed vgimg origin to match other backends #179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is there a bug this is fixing?
On line 60 s/0./0/
|
|
@kortschak bug introduced in #26 |
Member
Contributor
Author
|
I'm not sure how to add a test that doesn't require visual inspection for this. |
Member
|
We can cope with a small png.
|
Member
|
Closing because we have a competing proposal with a test in #182. |
sbinet
added a commit
to sbinet-gonum/plot
that referenced
this pull request
Mar 27, 2015
Address gonum#179 by translating the image to (0,-h) so (0,0) is at the bottom-left corner. Add a test decorated with (!windows && x11) tags (the travis-ci nodes may or may not have x11 installed and configured.) Add a dummy canvas_nox11.go so 'go test ./...' also works on windows.
sbinet
added a commit
to sbinet-gonum/plot
that referenced
this pull request
Mar 29, 2015
- fixes gonum#179 for X11 too by translating the image to (0,-h) so (0,0) is at the bottom-left corner. - 'go test ./...' will skip the X11 test if $DISPLAY is not defined. - setup xvfb in travis-ci to test X11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.