Fixed cropping bug #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The fix is correct, but the tests are dependent on manual inspection. Rather than using vgimg and writing outthe resulting png, use a vg/recorder.Canvas and compare the resulting sets of vg operations mechanically (you could write the png to a bytes.Buffer, but I would prefer to be able to see that both things are sane).
|
vg/draw/draw_test.go
Outdated
Member
|
Chris, thanks for this and for your other changes too. Could you please explain this bug in a bit more detail (in fact, could you please add the explanation to the commit message)? I don't quite understand what's happening here, but I also don't understand why I started the canvas at -w/2, -h/2 either :) |
Member
|
It looks like it was an error in Seb's change to rect. The original code used an implicitly zero Min field. For some reason that got translated into what exists now.
|
Member
|
LGTM, once Dan's suggestions are in. |
Contributor
Author
|
I fixed the test to not require manual inspection |
Member
|
On mobile, so I'll do this properly later, but to get you started: you can reflect.DeepEqual-compare the recorder actions; now that it's not dependent on being visible, the inches can go away; obvious cleanup of commented out sections; and what is the reason for the change to plotter/main.go?
|
vg/draw/draw_test.go
Outdated
Member
There was a problem hiding this comment.
Change the format string to "unexpected result: %+v != %+v".
Member
|
LGTM after minor nits. Then rebase onto gonum/plot master if necessary and squash. |
Member
|
Thanks, Chris. |
|
This change broke all the example images generated by plotter/main.go. |
ctessum
added a commit
to ctessum/plot
that referenced
this pull request
Mar 20, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with the draw.Canvas.Crop() function. I've added a test to document it. The test does cropping two different ways, the rectangles of which should be the same, and produces two output images that should also be the same. In the current version the two methods yield different results. The change that I made fixes this bug.