fix: Propagate app taints to the apps importers - #73
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughApp analysis now seeds taint for every export from each app entrypoint, including whole-package taint for side-effect-only entrypoints. Release metadata is updated to version 0.24.1. ChangesApp taint propagation
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@main.go`:
- Around line 303-309: Update the taint propagation around
CollectEntrypointExports so an entrypoint with len(exports) == 0 seeds the
existing wildcard/whole-app marker in allUpstreamTaint rather than an empty set;
preserve per-export tainting for non-empty results, and add a regression test
covering bare or dynamic imports of a side-effect-only affected entrypoint.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e6b48b1c-0ee7-41c3-9e9d-338b091162c3
📒 Files selected for processing (3)
CHANGELOG.mdVERSIONmain.go
6706672 to
914f708
Compare
Risk: low
Summary by CodeRabbit
Bug Fixes
Chores