1077 Remove user from a project

[cipous]

No description provided.

[ghost]

Build succeeded (check pipeline).

[cipous]

fixes #1077

[cipous]

I am not sure if AT will pass... :|

[cipous]

Please can you give me hint how to fix dependency issue? In log I can see
[WARNING] Used undeclared dependencies found:
[WARNING] junit:junit:jar:4.12:test

Thanks.

[ghost]

Build succeeded (check pipeline).

[peter-plochan]

Thanks for the contribution 👍
See comments below

[ghost]

Build succeeded (check pipeline).

[ghost]

Build succeeded (check pipeline).

[codecov-commenter]

Codecov Report

Merging #1079 (6ee8c97) into master (2aeea4a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1079      +/-   ##
============================================
+ Coverage     83.12%   83.16%   +0.04%     
- Complexity     2597     2607      +10     
============================================
  Files           343      345       +2     
  Lines          6641     6675      +34     
  Branches        477      480       +3     
============================================
+ Hits           5520     5551      +31     
- Misses          925      927       +2     
- Partials        196      197       +1     

Impacted Files	Coverage Δ
...m/gooddata/sdk/service/project/ProjectService.java	79.25% <100.00%> (+1.79%)	⬆️
...m/gooddata/sdk/service/account/AccountService.java	77.61% <0.00%> (-1.70%)	⬇️
...ain/java/com/gooddata/sdk/model/project/Users.java	100.00% <0.00%> (ø)
...om/gooddata/sdk/model/project/UsersSerializer.java	100.00% <0.00%> (ø)
...oddata/sdk/model/account/AccountsDeserializer.java	100.00% <0.00%> (ø)
.../java/com/gooddata/sdk/model/account/Accounts.java	100.00% <0.00%> (ø)
...n/java/com/gooddata/sdk/model/account/Account.java	79.62% <0.00%> (+0.78%)	⬆️
.../sdk/service/account/AccountNotFoundException.java	85.71% <0.00%> (+10.71%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2aeea4a...6ee8c97. Read the comment docs.

[liry]

Please can you give me hint how to fix dependency issue? In log I can see
[WARNING] Used undeclared dependencies found:
[WARNING] junit:junit:jar:4.12:test

Thanks.

I can see that you already found out the reason (using junit instead of testng in ATs). ;)

[ghost]

Build succeeded (check pipeline).

[cipous]

@liry I have applied all your suggestions, now should I write more tests as you extended exception handling?

[ghost]

Build succeeded (check pipeline).

[cipous]

I will have to implement also #1078, dont rush with release

[liry]

@liry I have applied all your suggestions, now should I write more tests as you extended exception handling?

Yes, adding these to ITs would be great

[ghost]

Build succeeded (check pipeline).

[liry]

I am not sure if AT will pass... :|

I tried them and they passed ;)

[liry]

And in the end please squash those commits and we can merge it ;)

[ghost]

Build succeeded (check pipeline).

[cipous]

squashed. Please see also https://github.com/gooddata/gooddata-java/pull/1080/files, we need to agree on api.

[ghost]

Build succeeded (gate pipeline).

• https://checklist.intgdc.com/job/compliance/job/gooddata-java-merge-compliance-check/259/ : SUCCESS in 31s
• https://checklist.intgdc.com/job/compliance/job/gooddata-java-fossa-scanning-zuul-el7/98/ : SUCCESS in 1m 12s (non-voting)