Skip to content

1078 List projects for a user#1081

Merged
1 commit merged intogooddata:masterfrom
cipous:1078_list_projects_for_user
Sep 15, 2021
Merged

1078 List projects for a user#1081
1 commit merged intogooddata:masterfrom
cipous:1078_list_projects_for_user

Conversation

@cipous
Copy link
Copy Markdown

@cipous cipous commented Sep 14, 2021

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Sep 14, 2021

Build succeeded (check pipeline).

@cipous
Copy link
Copy Markdown
Author

cipous commented Sep 14, 2021

fixes #1078

@cipous cipous force-pushed the 1078_list_projects_for_user branch from e2165ff to 432669b Compare September 14, 2021 12:01
@ghost
Copy link
Copy Markdown

ghost commented Sep 14, 2021

Build succeeded (check pipeline).

@cipous cipous force-pushed the 1078_list_projects_for_user branch from 432669b to 97186ce Compare September 14, 2021 12:27
@ghost
Copy link
Copy Markdown

ghost commented Sep 14, 2021

Build succeeded (check pipeline).

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 14, 2021 •
edited
Loading

Codecov Report

Merging #1081 (f1177fe) into master (835790c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head f1177fe differs from pull request most recent head f733d0c. Consider uploading reports for the commit f733d0c to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1081      +/-   ##
============================================
+ Coverage     83.16%   83.17%   +0.01%     
- Complexity     2607     2610       +3     
============================================
  Files           345      345              
  Lines          6675     6680       +5     
  Branches        480      480              
============================================
+ Hits           5551     5556       +5     
  Misses          927      927              
  Partials        197      197
Impacted Files Coverage Δ
...m/gooddata/sdk/service/project/ProjectService.java 79.79% <100.00%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 835790c...f733d0c. Read the comment docs.

liry
liry reviewed Sep 14, 2021
View reviewed changes
Comment thread gooddata-java/src/main/java/com/gooddata/sdk/service/project/ProjectService.java Outdated
@cipous cipous force-pushed the 1078_list_projects_for_user branch from 97186ce to de85739 Compare September 14, 2021 13:09
@ghost
Copy link
Copy Markdown

ghost commented Sep 14, 2021

Build succeeded (check pipeline).

@cipous cipous force-pushed the 1078_list_projects_for_user branch from de85739 to 89f1198 Compare September 14, 2021 13:10
@ghost
Copy link
Copy Markdown

ghost commented Sep 14, 2021

Build succeeded (check pipeline).

@cipous
Copy link
Copy Markdown
Author

cipous commented Sep 14, 2021

@liry please check now, it would be great if we can merge and release asap:) I am ready to respond immediately on your requests.

@cipous
Copy link
Copy Markdown
Author

cipous commented Sep 15, 2021

@liry17 @peter-plochan please could you check it?

liry
liry reviewed Sep 15, 2021
View reviewed changes
Comment thread gooddata-java/src/test/java/com/gooddata/sdk/service/project/ProjectServiceIT.java Outdated
liry
liry reviewed Sep 15, 2021
View reviewed changes
Comment thread gooddata-java/src/main/java/com/gooddata/sdk/service/project/ProjectService.java Outdated
liry
liry reviewed Sep 15, 2021
View reviewed changes
Comment thread gooddata-java/src/test/java/com/gooddata/sdk/service/project/ProjectServiceAT.java Outdated
@cipous cipous force-pushed the 1078_list_projects_for_user branch from 89f1198 to 692e6da Compare September 15, 2021 12:17
@ghost
Copy link
Copy Markdown

ghost commented Sep 15, 2021

Build succeeded (check pipeline).

liry
liry reviewed Sep 15, 2021
View reviewed changes
Comment thread gooddata-java/src/main/java/com/gooddata/sdk/service/project/ProjectService.java Outdated
@gooddata gooddata deleted a comment Sep 15, 2021
@liry liry added this to the next milestone Sep 15, 2021
@liry liry linked an issue Sep 15, 2021 that may be closed by this pull request
Implement List projects for a user #1078
Closed
@cipous cipous force-pushed the 1078_list_projects_for_user branch from 692e6da to c6146e1 Compare September 15, 2021 13:46
@ghost
Copy link
Copy Markdown

ghost commented Sep 15, 2021

Build succeeded (check pipeline).

liry
liry reviewed Sep 15, 2021
View reviewed changes
Comment thread gooddata-java/src/test/java/com/gooddata/sdk/service/project/ProjectServiceAT.java Outdated
@ghost
Copy link
Copy Markdown

ghost commented Sep 15, 2021

Build succeeded (check pipeline).

@cipous cipous force-pushed the 1078_list_projects_for_user branch from f1177fe to f733d0c Compare September 15, 2021 14:15
@ghost
Copy link
Copy Markdown

ghost commented Sep 15, 2021

Build succeeded (check pipeline).

@liry liry added the merge label Sep 15, 2021
@ghost ghost removed the merge label Sep 15, 2021
@ghost ghost merged commit 57367d2 into gooddata:master Sep 15, 2021
@ghost
Copy link
Copy Markdown

ghost commented Sep 15, 2021

Build succeeded (gate pipeline).

@liry
Copy link
Copy Markdown
Contributor

liry commented Sep 15, 2021

@cipous FYI: both issues you contributed recently have been released in version 3.10.0+api3 ;)

@cipous
Copy link
Copy Markdown
Author

cipous commented Sep 15, 2021

@liry thanks, I guess it wont be last cooperation since we would like to switch completely to sdk. Btw can you address #1049 which is also from us...

@liry
Copy link
Copy Markdown
Contributor

liry commented Sep 17, 2021

@cipous yes, the PR is complete now, so I hope we will release it soon ;)

@liry
Copy link
Copy Markdown
Contributor

liry commented Sep 17, 2021

@cipous FYI: version 3.11.0+api3 with that timezone management is ready to be used ;)

@cipous
Copy link
Copy Markdown
Author

cipous commented Sep 17, 2021

@liry thanks a lot!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liry liry liry left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

3.10.0+api3

Development

Successfully merging this pull request may close these issues.

Implement List projects for a user

3 participants

@cipous @codecov-commenter @liry