[bot] Merge master/58485168 into rel/dev - #1778
Merged
Merged
Conversation
…inds latency_breakdown (#1758) was wired into only the 9 test kinds the downstream consumer had enabled, not the SDK's full kind catalog. This closes the gap for metric_skill, alert_skill, agentic_search, agentic_general_question and agentic_kda_skill -- all of which already receive real tool_call_events/ reasoning_step_events through the same chat pipeline as their wired siblings. dashboard_summary is deliberately excluded: it calls a plain REST /summary endpoint, not the chat/SSE pipeline, so it has no tool-call or reasoning-step events to report at all. Also extracts the per-turn timestamp/index rebasing -- previously hand-copied identically across alert_skill, metric_skill, visualization and conversation, and needed a fifth time for agentic_kda_skill's simulated-user loop -- into one shared shift_and_index_events() in models.py. All five call sites use it, so there is one implementation rather than five that can drift. Tests: a two-iteration kda test asserts the real rebasing math (iteration 2's call_ts shifted by iteration 1's turn_wall_clock_sec, tool index from 0 while reasoning index starts from 1), plus per-run event-propagation guards for search_tool (which still builds its result in two places) and general_question. Rebased onto #1771, which restructured the same K-run loops: general_question now builds all K runs and one shared detail dict in a single place, so the propagation fix collapses to one site there; search_tool still has two.
…ng-kinds feat(gooddata-eval): extend detail.latency_breakdown to 5 remaining kinds
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## rel/dev #1778 +/- ##
===========================================
+ Coverage 81.59% 81.67% +0.08%
===========================================
Files 275 275
Lines 19851 19835 -16
===========================================
+ Hits 16197 16201 +4
+ Misses 3654 3634 -20 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Automated PR to perform merge from master into rel/dev with changes up to 5848516 (created by https://github.com/gooddata/gooddata-python-sdk/actions/runs/33851719856).