Skip to content

Fix skip actions#1090

Merged
panjan merged 1 commit intogooddata:developfrom
kubamahnert:TMA-skip-actions
Jan 15, 2018
Merged

Fix skip actions#1090
panjan merged 1 commit intogooddata:developfrom
kubamahnert:TMA-skip-actions

Conversation

@kubamahnert
Copy link
Copy Markdown
Contributor

No description provided.

@kubamahnert kubamahnert requested a review from panjan January 12, 2018 14:56
Comment thread lib/gooddata/lcm/lcm2.rb
skip_actions = (params.skip_actions || [])
actions = actions.reject do |action|
skip_actions.include?(action.to_s)
skip_actions.include?(action.name.split('::').last)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calls 'action.name' 2 times (DuplicateMethodCall)

@ghost
Copy link
Copy Markdown

ghost commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

@panjan panjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ!

@panjan panjan added the merge label Jan 12, 2018
@ghost
Copy link
Copy Markdown

ghost commented Jan 12, 2018

@ghost ghost removed the merge label Jan 12, 2018
@ghost
Copy link
Copy Markdown

ghost commented Jan 15, 2018

Build failed (gate pipeline).

@ghost ghost removed the merge label Jan 15, 2018
@panjan
Copy link
Copy Markdown
Contributor

panjan commented Jan 15, 2018

ok to merge

@panjan panjan added the merge label Jan 15, 2018
@ghost
Copy link
Copy Markdown

ghost commented Jan 15, 2018

@ghost ghost removed the merge label Jan 15, 2018
@panjan panjan added the merge label Jan 15, 2018
@ghost
Copy link
Copy Markdown

ghost commented Jan 15, 2018

@ghost ghost removed the merge label Jan 15, 2018
@panjan panjan added the merge label Jan 15, 2018
@ghost
Copy link
Copy Markdown

ghost commented Jan 15, 2018

@ghost ghost removed the merge label Jan 15, 2018
@panjan
Copy link
Copy Markdown
Contributor

panjan commented Jan 15, 2018

extended test - staging

@ghost
Copy link
Copy Markdown

ghost commented Jan 15, 2018

@panjan panjan merged commit 8df9562 into gooddata:develop Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants