TMA-732: fix edge cases for user input sanitized MUFs#1092
Merged
1 commit merged intogooddata:developfrom Feb 6, 2018
Merged
Conversation
yenkins
reviewed
Jan 18, 2018
| end | ||
|
|
||
| context 'when using sync_multiple_projects_based_on_custom_id mode' do | ||
| let(:params) do |
There was a problem hiding this comment.
Similar code found in synchronize_user_filters_spec.rb:79, synchronize_user_filters_spec.rb:148 (mass = 52)
yenkins
reviewed
Jan 18, 2018
| end | ||
| let(:CSV) { double('CSV') } | ||
|
|
||
| before do |
There was a problem hiding this comment.
Identical code found in synchronize_user_filters_spec.rb:93, synchronize_user_filters_spec.rb:162 (mass = 152)
yenkins
reviewed
Jan 18, 2018
| CSV.foreach(File.open(data_source.realize(params), 'r:UTF-8'), headers: csv_with_headers, return_headers: false, encoding: 'utf-8') do |row| | ||
| filters << row.to_hash | ||
| end | ||
| fail 'The filter set can not be empty when using sync_multiple_projects_based_on_custom_id mode' if filters.empty? |
There was a problem hiding this comment.
Calls 'filters.empty?' 2 times (DuplicateMethodCall)
yenkins
reviewed
Jan 18, 2018
| it 'fails if the MUF set is empty' do | ||
| expect(File).to receive(:open) | ||
| expect(CSV).to receive(:foreach) | ||
| expect { subject.class.call(params) }.to raise_error /The filter set can not be empty/ |
There was a problem hiding this comment.
Lint/AmbiguousRegexpLiteral: Ambiguous regexp literal. Parenthesize the method arguments if it's surely a regexp literal, or add a whitespace to the right of the / if it should be a division.
|
Build failed (check pipeline).
|
panjan
approved these changes
Jan 18, 2018
yenkins
reviewed
Jan 19, 2018
|
|
||
| context 'when using sync_multiple_projects_based_on_custom_id mode' do | ||
| include_context 'using mode with custom_id' | ||
| let(:params) do |
There was a problem hiding this comment.
Similar code found in synchronize_user_filters_spec.rb:94, synchronize_user_filters_spec.rb:153 (mass = 52)
|
Build failed (check pipeline).
|
|
Build succeeded (check pipeline).
|
Contributor
|
ok to merge |
yenkins
reviewed
Jan 22, 2018
| def self.sanitize_filters_to_delete(to_delete, users_brick_input, project_users) | ||
| return to_delete unless users_brick_input && users_brick_input.any? | ||
| user_profiles = users_brick_input.map do |user| | ||
| result = project_users.find { |u| u.login == user['login'] } |
There was a problem hiding this comment.
Calls 'filter[:label]' 4 times (DuplicateMethodCall)
yenkins
reviewed
Jan 22, 2018
| def self.sanitize_filters_to_delete(to_delete, users_brick_input, project_users) | ||
| return to_delete unless users_brick_input && users_brick_input.any? | ||
| user_profiles = users_brick_input.map do |user| | ||
| result = project_users.find { |u| u.login == user['login'] } |
There was a problem hiding this comment.
Contains iterators nested 3 deep (NestedIterators)
yenkins
reviewed
Jan 22, 2018
| def self.sanitize_filters_to_delete(to_delete, users_brick_input, project_users) | ||
| return to_delete unless users_brick_input && users_brick_input.any? | ||
| user_profiles = users_brick_input.map do |user| | ||
| result = project_users.find { |u| u.login == user['login'] } |
There was a problem hiding this comment.
Has the variable name 'l' (UncommunicativeVariableName)
|
Build failed (gate pipeline).
|
ghost
removed
the
|
Build succeeded (gate pipeline).
|
ghost
merged commit
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.