Skip to content

TMA-691 changed output to human readable part of colect data product action#1099

Merged
2 commits merged intogooddata:developfrom
Hahihula:TMA-691
Feb 8, 2018
Merged

TMA-691 changed output to human readable part of colect data product action#1099
2 commits merged intogooddata:developfrom
Hahihula:TMA-691

Conversation

@Hahihula
Copy link
Copy Markdown
Contributor

@Hahihula Hahihula commented Feb 5, 2018

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Feb 5, 2018

Build failed (check pipeline).

@ghost
Copy link
Copy Markdown

ghost commented Feb 5, 2018

Build failed (check pipeline).

Comment thread deprecations.txt Outdated
@@ -0,0 +1,6 @@
Using `should_not` from rspec-expectations' old `:should` syntax without explicitly enabling the syntax is deprecated. Use the new `:expect` syntax or explicitly enable `:should` with `config.expect_with(:rspec) { |c| c.syntax = :should }` instead. Called from /home/hahihula/work/gooddata-ruby/spec/unit/actions/collect_data_product_spec.rb:9:in `block (2 levels) in <top (required)>'.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this unrelated file

@kubamahnert
Copy link
Copy Markdown
Contributor

Please include the jira task identifier in the merge request title as customary, thanks!

@Hahihula Hahihula changed the title changed output to human readable part of colect data product action TMA-691 changed output to human readable part of colect data product action Feb 6, 2018
@ghost
Copy link
Copy Markdown

ghost commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

@panjan panjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ! Thank you.

@panjan panjan added the merge label Feb 8, 2018
@ghost
Copy link
Copy Markdown

ghost commented Feb 8, 2018

@ghost ghost merged commit d712ec4 into gooddata:develop Feb 8, 2018
@ghost ghost removed the merge label Feb 8, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants