Skip to content

Revert "TMA-819: requests to the profile/email@addr API always use downcase"#1118

Merged
kubamahnert merged 1 commit intodevelopfrom
revert-1114-TMA-819
Mar 9, 2018
Merged

Revert "TMA-819: requests to the profile/email@addr API always use downcase"#1118
kubamahnert merged 1 commit intodevelopfrom
revert-1114-TMA-819

Conversation

@kubamahnert
Copy link
Copy Markdown
Contributor

Reverts #1114

We should only merge this AFTER the tests are merged into gerrit appstore.

@kubamahnert kubamahnert requested review from Hahihula and panjan March 9, 2018 11:26
@ghost
Copy link
Copy Markdown

ghost commented Mar 9, 2018

project_user = project_users.find { |u| u.login == login }
project_user.nil? ? ('/gdc/account/profile/' + safe_login) : project_user.profile_url

project_user.nil? ? ('/gdc/account/profile/' + login) : project_user.profile_url
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performs a nil-check (NilCheck)

@Hahihula
Copy link
Copy Markdown
Contributor

Hahihula commented Mar 9, 2018

Seems reasonable

@kubamahnert kubamahnert merged commit 801b415 into develop Mar 9, 2018
@caohhung caohhung deleted the revert-1114-TMA-819 branch May 29, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants