BUGFIX: TMA-1653 fix issue using find function of Enumerator#1646
Merged
1 commit merged intogooddata:masterfrom May 5, 2020
tqtu:TMA-1653-1
Merged
BUGFIX: TMA-1653 fix issue using find function of Enumerator#16461 commit merged intogooddata:masterfrom tqtu:TMA-1653-1
1 commit merged intogooddata:masterfrom
tqtu:TMA-1653-1
Conversation
Contributor
Author
|
extended test |
|
Build succeeded (check-extended pipeline). |
Contributor
Author
|
extended test |
|
Build succeeded (check-extended pipeline). |
|
Build succeeded (check pipeline). |
Contributor
|
please update brick version in VERSION file to release LCM bricks |
|
Build succeeded (check pipeline). |
| offset += limit | ||
| end | ||
|
|
||
| all_users |
Contributor
There was a problem hiding this comment.
we should return all_users.each which is an enumerator instead of an array.
If we change the returned type, we don't know how it impact to customer.
There was a problem hiding this comment.
This should not have any impact, we mentioned in the documentation return Array.
@return [ArrayGoodData::User] List of users
tqtu
changed the title
ghost
removed
the
ghost
merged commit
|
Build succeeded (gate pipeline).
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.