Allow gooddata-ruby to be used with Rails 6.1 #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.5+ (required by Rails 6) provides Hash#compact and Hash#compact! natively, so requiring active_support/core_ext/hash/compact is no longer necessary. Requiring it will raise LoadError in Rails 6.1.
|
Build failed (check pipeline).
|
|
@phong-nguyen-duy please review/merge. |
Contributor
|
ok to test |
Contributor
|
extended test |
|
Build succeeded (check-extended pipeline). |
|
Build succeeded (check pipeline). |
|
We've test the following LCM bricks with image tag be1e509:
And they are working fine |
sangtm
approved these changes
Feb 1, 2021
Sonar scan result
More detail, see in https://sonarqube-dev.intgdc.com/dashboard?id=gooddata-ruby-gate-PR1715 |
ghost
removed
the
ghost
merged commit
|
Build succeeded (gate pipeline).
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there 🙌
We're preparing for upgrading our app to Rails 6.1 and found out that GoodData-ruby does not allow it yet. So, on this patch, we allow activesupport 6.1 to be installed and its compatibility.
Requiring
active_support/core_ext/hash/compacton Rails 6.1 causes an error. Also shouldn't be needed for Ruby 2.5+. Check https://github.com/rails/rails/blob/6-0-stable/activesupport/lib/active_support/core_ext/hash/compact.rbI've tried running specs locally.. but most of them are not running because they are trying to hit your staging servers. So I'm not sure.. if this is all the work needed!