FEATURE: MSF-20653 Support Blob Storage input source#1784
FEATURE: MSF-20653 Support Blob Storage input source#17841 commit merged intogooddata:developfrom tqtu:MSF-20653-2
Conversation
|
Build succeeded (check pipeline). |
|
Build succeeded (check pipeline). |
|
Build succeeded (check pipeline). |
| raise("Data Source needs a client to Blob Storage to be able to get blob file but 'blobStorage_client' is empty.") unless options['blobStorage_client'] | ||
|
|
||
| # rubocop:disable Naming/VariableName | ||
| if options['blobStorage_client']['connectionString'] || options['blobStorage_client']['container'] |
There was a problem hiding this comment.
Both connectionString and container are mandatory
There was a problem hiding this comment.
Fixed, connectionString and container are mandatory
|
Build succeeded (check pipeline). |
| require 'csv' | ||
| require 'digest' | ||
| require 'open-uri' | ||
| require_relative '../cloud_resources/blobstorage/blobstorage_client' |
There was a problem hiding this comment.
should load blob storage api only when user defined blob storage input source
There was a problem hiding this comment.
Fixed, Moved require_relative into blobStorage
|
@tqtu please add integration test to cover the new input source type |
|
Build succeeded (check pipeline). |
|
Build succeeded (check pipeline). |
| GoodData.gd_logger.info("Realizing download from Blob Storage. Container #{@container}.") | ||
| connect | ||
| filename = "#{SecureRandom.urlsafe_base64(6)}_#{Time.now.to_i}.csv" | ||
| blob_name = @path ? "#{file}" : "#{@path}/#{file}" |
There was a problem hiding this comment.
should handle the case @path ends with slash (/)
There was a problem hiding this comment.
The path added delete_suffix to remove slash
|
Build succeeded (check pipeline). |
Sonar scan resultMore detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ruby-gate-PR1784 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
ghost
removed
the
ghost
merged commit
|
Build succeeded (gate pipeline).
|
3 participants
No description provided.