FEATURE: MSF-20653 Update message error blob storage#1786
Merged
1 commit merged intogooddata:developfrom Jul 2, 2021
tqtu:MSF-20653-2
Merged
FEATURE: MSF-20653 Update message error blob storage#17861 commit merged intogooddata:developfrom tqtu:MSF-20653-2
1 commit merged intogooddata:developfrom
tqtu:MSF-20653-2
Conversation
|
Build succeeded (check pipeline). |
Contributor
Author
|
ok to test |
|
Build succeeded (check pipeline). |
| elsif e.message && e.message.include?(INVALID_BLOB_CONTAINER_MESSAGE) | ||
| raise INVALID_BLOB_CONTAINER_FORMED_MESSAGE | ||
| else | ||
| raise INVALID_BLOB_GENERAL_MESSAGE |
Contributor
There was a problem hiding this comment.
how about the path is not found
Contributor
Author
There was a problem hiding this comment.
With the wrong pass, BlobNotFound message will be thrown,
I fixed and rethrow to path not found
| begin | ||
| connect | ||
| filename = "#{SecureRandom.urlsafe_base64(6)}_#{Time.now.to_i}.csv" | ||
| blob_name = @path ? "#{file}" : "#{@path.delete_suffix('/')}/#{file}" |
Contributor
Author
There was a problem hiding this comment.
Yes, the logic code is reverse
I fixed its.
|
Build succeeded (check pipeline). |
|
Build succeeded (check pipeline). |
Sonar scan resultMore detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ruby-gate-PR1786 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
ghost
removed
the
ghost
merged commit
|
Build succeeded (gate pipeline).
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.