Skip to content

FEATURE: MSF-22129 add support mysql input source#1818

Merged
1 commit merged intogooddata:masterfrom
tqtu:MSF-22129
Dec 10, 2021
Merged

FEATURE: MSF-22129 add support mysql input source#1818
1 commit merged intogooddata:masterfrom
tqtu:MSF-22129

Conversation

@tqtu
Copy link
Copy Markdown
Contributor

@tqtu tqtu commented Nov 25, 2021

No description provided.

@ghost
Copy link
Copy Markdown

ghost commented Nov 25, 2021

@ghost
Copy link
Copy Markdown

ghost commented Nov 29, 2021

@ghost
Copy link
Copy Markdown

ghost commented Nov 29, 2021

@ghost
Copy link
Copy Markdown

ghost commented Dec 2, 2021

host = matches[0][0]
port = matches[0][2]&.to_i || MYSQL_DEFAULT_PORT

"#{JDBC_MYSQL_PROTOCOL}#{host}:#{port}/#{@database}?sslmode=#{get_ssl_mode(@ssl_mode)}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the parameter useCursorFetch=true

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The param was added to JDBC url

@ghost
Copy link
Copy Markdown

ghost commented Dec 6, 2021

@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2021

@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2021

@tqtu
Copy link
Copy Markdown
Contributor Author

tqtu commented Dec 7, 2021

extended test

@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2021

Build succeeded (check-extended pipeline).

@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2021

@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2021

@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2021

@ghost
Copy link
Copy Markdown

ghost commented Dec 7, 2021

@ghost
Copy link
Copy Markdown

ghost commented Dec 8, 2021

@ghost
Copy link
Copy Markdown

ghost commented Dec 9, 2021

@yenkins
Copy link
Copy Markdown

yenkins commented Dec 10, 2021

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ruby-gate-PR1818

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Dec 10, 2021
@ghost ghost merged commit 3dd4e65 into gooddata:master Dec 10, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants