Skip to content

fix: support for italian and unknown languages #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Mar 22, 2024
Merged

fix: support for italian and unknown languages #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.7.63
3.7.64
6 changes: 3 additions & 3 deletions lib/gooddata/models/domain.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ class Domain < Rest::Resource
'pt-PT' => 'Portuguese/Portugal',
'fr-FR' => 'French',
'de-DE' => 'German',
'ja-JP' => 'Japanese'
'ja-JP' => 'Japanese',
'it-IT' => 'Italian'
}

class << self
Expand Down Expand Up @@ -292,9 +293,8 @@ def ensure_user_language(user_data)
language = user_data[:language] || 'en-US'
unless USER_LANGUAGES.keys.include?(language)
available_languages = USER_LANGUAGES.map { |k, v| "#{k} (#{v})" }.join(', ')
GoodData.logger.warn "The language for user '#{user_data[:login]}' will be English because '#{language}' is an invalid value. \
GoodData.logger.warn "The language for user '#{user_data[:login]}' will be '#{language}' but it may be not valid, since it's not declared to be known by the client. \
Available values for setting language are: #{available_languages}."
language = 'en-US'
end
language
end
Expand Down