Conversation
- タブコンポーネントを新規作成 - タブのバリアント（solid, line, ghost）を実装 - タブの基本的なレンダリングテストを追加 - タブのユーザーインタラクションに関するテストを追加 - タブのアクセシビリティに関するテストを追加
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- 不要なインポートを削除 - Reactのインポートを整理 - コードの可読性を向上
touyou
reviewed
Jul 11, 2025
Comment on lines
+18
to
+27
| const tabsTriggerVariants = cva( | ||
| [ | ||
| "inline-flex items-center justify-center gap-1.5 whitespace-nowrap transition-colors duration-150", | ||
| "px-3 py-2 character-3-regular-pro", | ||
| "focus-visible:outline-none", | ||
| ], | ||
| { | ||
| variants: { | ||
| variant: { | ||
| solid: [ |
- TabsTriggerのカーソルスタイルをポインタに変更 - 無効状態のカーソルスタイルを追加
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Tabsコンポーネントを新規作成
変更内容
動作確認
pnpm lintを実行pnpm buildを実行してプロジェクトが正常にビルドされることを確認pnpm testを実行してテストがすべて成功することを確認関連 Issue
[SPARKLE-640] Tabsコンポーネントを開発時に使用できる goodpatch/sparkle-design-issue-archive#30
Close goodpatch/sparkle-design-issue-archive#30