Buttonの修正 - #121
Merged
Merged
Conversation
- 角丸変数に各値の説明コメントを追加 - シャドウ変数のフォーマットを統一
- ボタンコンポーネントの子要素を<span className="px-1">でラップ
- ボタンコンポーネントのスピナーにクラス名"text-current"を追加 - ボタンコンポーネントの子要素に"antialiased"クラスを追加 - アイコンコンポーネントのクラス名に"antialiased"を追加
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- 角丸変数のコメントを追加 - シャドウ変数のフォーマットを改善
There was a problem hiding this comment.
Pull Request Overview
This PR implements button component improvements as outlined in the design specifications, focusing on visual refinements and consistency.
- Updated border radius values in CSS variables to align with design system
- Added antialiasing support for better text rendering on icons and button content
- Enhanced spinner color inheritance for better visual consistency
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/app/sparkle-design.css | Updated radius CSS variables with precise pixel values and added clarifying comments |
| src/components/ui/icon/index.tsx | Added antialiasing class for smoother icon rendering |
| src/components/ui/button/index.tsx | Added wrapper span with antialiasing and improved spinner color inheritance |
ore0
reviewed
Aug 13, 2025
| </> | ||
| ) : ( | ||
| children | ||
| <span className="px-1 antialiased">{children}</span> |
There was a problem hiding this comment.
antialiasedを使用する方針ってプロジェクト全体で決まってましたっけ。
全体にかけられるといいなと思いつつ、今のままだと適用する箇所としない箇所が発生しそう...？
Member
Author
There was a problem hiding this comment.
→ mtgにて決定
全体にsubpixel-antialiasedをかける
There was a problem hiding this comment.
antialiasedの定義をここでカットすればこのPRはマージしても問題なしです！
- ボタンコンポーネントのスタイルを改善 - アイコンコンポーネントのクラス名を整理
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
変更内容
動作確認
pnpm lintを実行pnpm buildを実行してプロジェクトが正常にビルドされることを確認pnpm testを実行してテストがすべて成功することを確認関連 Issue