Fix attached tendon wrap model pointers - #3406
Merged
copybara-service[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
quagla
marked this pull request as ready for review
July 20, 2026 07:43
quagla
approved these changes
Jul 20, 2026
copybara-service
Bot
merged commit Jul 20, 2026
5ea4c3a
into
google-deepmind:main
20 of 21 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft follow-up for #3157 / #3152, based on the original fix from @mar-yan24.
This keeps the change narrow:
mjCTendon::CopyFromSpec()Local validation:
git diff --checkcmake -S . -B /tmp/mujoco-pr3157-build -DMUJOCO_BUILD_TESTS=ON -DMUJOCO_TEST_PYTHON_UTIL=OFF -DCMAKE_BUILD_TYPE=Releasecmake --build /tmp/mujoco-pr3157-build --target user_api_test -j2/tmp/mujoco-pr3157-build/bin/user_api_test --gtest_filter='MujocoTest.AttachSpatialTendonWithoutSidesite'Opening as draft to avoid superseding the existing approved PR unless maintainers prefer this rebased/test-extended version.