Skip to content

Conversation

@Chamikajaya
Copy link

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Mar 22, 2025
@@ -1,20 +1,19 @@
{
"cells": [
{
Copy link
Collaborator

@Giom-V Giom-V Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #2.      model='gemini-2.0-flash',

Can you add a "MODEL_ID" variable like this?

MODEL_ID="gemini-2.0-flash" # @param ["gemini-2.0-flash-lite","gemini-2.0-flash","gemini-2.0-pro-exp-02-05"] {"allow-input":true, isTemplate: true}

As it would make the notebook easier to maintain in the future.


Reply via ReviewNB

@@ -1,20 +1,19 @@
{
"cells": [
{
Copy link
Collaborator

@Giom-V Giom-V Mar 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #3.      contents=[prompt, blog_file, blog_file2, audio_file ],

Ntipicking, but can you remove the extra space at the end?


Reply via ReviewNB

@Giom-V
Copy link
Collaborator

Giom-V commented Mar 31, 2025

Thanks @Chamikajaya for the submission and sorry for the delayed review.

I just added a couple of minor comments to make the notebook easier to understand and to maintain.

Can you also check the lint and format failures and fix them (format is likely because you haven't run the formatting script, lint because a "we" needs to be changed into a "you"). If you see a lint error reported in the template notebook, just ignore it, it's because of a CL you merged with.

Thanks again!

@andycandy
Copy link
Collaborator

@Giom-V If this PR has been abandoned, I can take continue this

@Giom-V
Copy link
Collaborator

Giom-V commented Apr 22, 2025

@Giom-V If this PR has been abandoned, I can take continue this

Yes, do it if you want.

@Giom-V Giom-V closed this Apr 22, 2025
@andycandy
Copy link
Collaborator

@Giom-V Of course :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants