Migrating vectordb with chroma #610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
andycandy
commented
Mar 25, 2025
andycandy
commented
- Updated module google-generativeai to use google-genai
- Refactored imports
- nbfmt
- lint checked
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
status:awaiting review
Giom-V
reviewed
Mar 31, 2025
Collaborator
|
Thank for the submission @andycandy. I just added a bit of nitpicking regarding the strings formatting. You already know I think but just ignore the lint fail related to the template notebook. |
Collaborator
Author
|
All done !@Giom-V |
Giom-V
approved these changes
Mar 31, 2025
Collaborator
Giom-V
left a comment
Giom-V
left a comment
There was a problem hiding this comment.
All good. Thanks again @andycandy
Collaborator
Author
|
Most welcome @Giom-V |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.