Updated Providing_base_cases.ipynb to use google-genai #643
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
github-actions
bot
added
status:awaiting review
| { | ||
| "cell_type": "markdown", | ||
| "metadata": { | ||
| "id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Line #2. You are an assistant that helps tourists around the world to plan their vacation. Your responsibilities are:
Can you add some indentation to improve readability? Like
instructions = """
You are an assistant that helps tourists around the world to plan their vacation. Your responsibilities are:
1. Helping book the hotel.
2. Recommending restaurants.
3. Warning about potential dangers.
If other request is asked return "I cannot help with this request."
"""
Reply via ReviewNB
| { | ||
| "cell_type": "markdown", | ||
| "metadata": { | ||
| "id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Line #1. MODEL_ID="gemini-2.0-flash" # @param ["gemini-2.0-flash-lite","gemini-2.0-flash","gemini-2.5-pro-exp-03-25"] {"allow-input":true, isTemplate: true}
We don't need to define the model all the time. I think once at the beginning of the notebook is enough.
Reply via ReviewNB
| { | ||
| "cell_type": "markdown", | ||
| "metadata": { | ||
| "id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Line #1. print("ON TOPIC:", on_topic_response.text)
Can you use display(Markdown()) to improve the rendering of the markdown?
Reply via ReviewNB
| { | ||
| "cell_type": "markdown", | ||
| "metadata": { | ||
| "id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
| { | ||
| "cell_type": "markdown", | ||
| "metadata": { | ||
| "id": "gy3KpnNx_Jl4" |
There was a problem hiding this comment.
Line #1. print('''## Specified genre:
Can you use display(Markdown()) to improve the rendering of the markdown? I also don't think the line breaks are needed.
Reply via ReviewNB
|
Thanks for the submission @Shi-pra-19! It's the first one if I'm not mistaken 🥳 I just added a couple of minor comments to make the notebook easier to understand. Can you also check the format failures. It is likely because you haven't run the formatting script. Thanks again! |
| "source": [ | ||
| "##### Copyright 2025 Google LLC." | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Could you update the model list so we can get this merged quickly?
MODEL_ID="gemini-2.5-flash-preview-05-20" # @param ["gemini-2.5-flash-preview-05-20", "gemini-2.5-pro-preview-05-06"] {"allow-input":true, isTemplate: true}
Reply via ReviewNB
| "source": [ | ||
| "##### Copyright 2025 Google LLC." | ||
| ] | ||
| }, |
There was a problem hiding this comment.
|
Fixed it. Let me know if I missed anything. |
Looks great overall! Just one small thing, could you avoid bumping the |
|
Looks good to me. @Giom-V |
3 participants
Updated module google-generativeai to use google-genai
Refactored imports