Skip to content

updated Story_Writing_with_Prompt_Chaning.ipynb to google-genai SDK#644

Merged
Giom-V merged 2 commits intogoogle-gemini:mainfrom
ROHANDWIVEDI2005:update2
Apr 3, 2025
Merged

updated Story_Writing_with_Prompt_Chaning.ipynb to google-genai SDK#644
Giom-V merged 2 commits intogoogle-gemini:mainfrom
ROHANDWIVEDI2005:update2

Conversation

@ROHANDWIVEDI2005
Copy link
Copy Markdown
Contributor

@ROHANDWIVEDI2005 ROHANDWIVEDI2005 commented Apr 3, 2025

Here I have removed the retry because I couldn't find any request_options parameter in the new SDK. If there is any change needed please let me know.
Screenshot 2025-04-03 163702

Also the previous token_count was much more than this one.
Screenshot 2025-04-03 163836
This might defeat the purpose of shocasing iterative generation. I think my editor is turncating the output. I will update this after the conformation of request_options

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder labels Apr 3, 2025
@Giom-V
Copy link
Copy Markdown
Collaborator

Giom-V commented Apr 3, 2025

Thanks @ROHANDWIVEDI2005 for the submission. I just think we should get rid of the function. Can you do that?

@Giom-V Giom-V self-assigned this Apr 3, 2025
@ROHANDWIVEDI2005
Copy link
Copy Markdown
Contributor Author

  • Removed function
  • Fixed truncate
  • nbfmt

@Giom-V Giom-V merged commit 015ee77 into google-gemini:main Apr 3, 2025
5 checks passed
@Giom-V
Copy link
Copy Markdown
Collaborator

Giom-V commented Apr 3, 2025

Thank you @ROHANDWIVEDI2005! The PR is approved and merged!

@ROHANDWIVEDI2005 ROHANDWIVEDI2005 deleted the update2 branch April 4, 2025 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:examples Issues/PR referencing examples folder status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants