Skip to content

Conversation

@sbeeredd04
Copy link

This pull request includes a small change to the quickstarts/file-api/requirements.txt and quickstarts/Tuning.ipynb files. The change updates a dependency by replacing google-generativeai with google-genai to reflect the correct package name, and modifies all the subsequent code cells in the notebook to use the latest SDK.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:quickstarts Issues/PR referencing quickstarts folder labels May 22, 2025
@sbeeredd04 sbeeredd04 changed the title Migration Updated quickstarts/Tuning.ipynb to use new google-genai SDK (#446) May 22, 2025
@sbeeredd04
Copy link
Author

@Giom-V I have made updates to this notebook. Please let me know if any changes are needed.

@sbeeredd04
Copy link
Author

@andycandy @Giom-V I just updated the notebook, lmk if there's anything else I should be doing

"source": [
"##### Copyright 2025 Google LLC."
]
},
Copy link
Collaborator

@andycandy andycandy Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #3.    print(json.dumps(model.to_json_dict(), indent=4))

As I commented earlier you shouldn't print the metadata here, as its already being printed in the next cell, you only need to print the model state here for now.


Reply via ReviewNB

@andycandy
Copy link
Collaborator

Thanks so much for your work on this, @sbeeredd04! There’s just a bit of code cleanup we might need to address later. Also, since part of the code is currently using deprecated elements, it might be better to hold off on merging this until the updated functionality becomes available in the google-genai package. That way, you can implement the full upgrade in one go, keeping everything consistent instead of mixing updated and outdated parts.

@sbeeredd04
Copy link
Author

Okay, that sounds good. Do you have any other suggestions that I could work on or need help with?

@andycandy
Copy link
Collaborator

andycandy commented Jun 18, 2025

This has to be closed as #804 is supposed to be removing the Tuning notebook and replacing it with a placeholder.

@andycandy andycandy closed this Jun 18, 2025
@Giom-V
Copy link
Collaborator

Giom-V commented Jun 18, 2025

@sbeeredd04 Sorry that the work you did could not make it. We recently decided to stop supporting tuning with the Gemini API and only with Vertex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants