feat(telemetry): implement Clearcut logging for startup statistics#21172
feat(telemetry): implement Clearcut logging for startup statistics#21172
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the CLI's telemetry capabilities by introducing a dedicated event for capturing detailed startup statistics. The change allows for better understanding of the CLI's initialization performance and environmental context, which is crucial for identifying bottlenecks and improving user experience across different platforms and setups. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi @yunaseoul, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
There was a problem hiding this comment.
Code Review
This pull request implements Clearcut logging for startup statistics. It introduces a new STARTUP_STATS event, adds the necessary metadata keys, and includes a new logStartupStatsEvent method in the ClearcutLogger. The changes are well-contained and correctly integrated into the existing telemetry system. The implementation appears solid, and I found no issues of high or critical severity.
|
Size Change: +811 B (0%) Total Size: 26 MB ℹ️ View Unchanged
|
Summary
Implement Clearcut logging for startup statistics to capture the CLI startup phases, OS platform, OS release, and Docker execution environment.
Details
This PR introduces the
STARTUP_STATSevent to the Clearcut logger. It adds the necessary event metadata keys toevent-metadata-key.tsand updatesloggers.tsto log theStartupStatsEventupon initialization.Related Issues
Related to #21161
How to Validate
.gemini/settings.json..gemini/telemetry.logfor theSTARTUP_STATSevent to ensure the startup phases, OS platform, and Docker status are recorded correctly.Pre-Merge Checklist