fix(caretaker): clear lock on NEEDS_HUMAN transition

[chadd28]

Summary

Clears lock.holder and lock.expires_at when an issue transitions to NEEDS_HUMAN after reaching max claim attempts in IssuesStore.

Details

When _acquire_lock_tx reached attempts >= 2, it transitioned the issue status to NEEDS_HUMAN but failed to clear the active lock fields (lock.holder and lock.expires_at). Setting these to None aligns NEEDS_HUMAN behavior with all other status transitions in IssuesStore.

How to Validate

Run the triage-worker unit test suite:

python -m unittest discover -s tools/caretaker-agent/cloudrun/triage-worker/tests

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request ensures consistency in the IssuesStore by cleaning up stale lock information when an issue reaches the maximum number of claim attempts and transitions to NEEDS_HUMAN. This prevents potential issues with lingering lock data after an issue has been escalated for human intervention.

Highlights

• Lock State Cleanup: Updated the _acquire_lock_tx method to explicitly clear lock.holder and lock.expires_at when an issue transitions to the NEEDS_HUMAN status.
• Test Verification: Updated the test_acquire_lock_two_strikes_constraint unit test to verify that the lock fields are correctly set to None during the transition.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

📊 PR Size: size/XS

• Lines changed: 4
• Additions: +4
• Deletions: -0
• Files changed: 2

[github-actions]

You already have 7 pull requests open. Please work on getting existing PRs merged before opening more.

[gemini-code-assist]

Code Review

This pull request updates the _acquire_lock_tx function in issues_store.py to clear the lock holder and expiration timestamp (setting them to None) when an issue's status is transitioned to NEEDS_HUMAN after multiple failed attempts. It also updates the corresponding unit tests in test_issues_store.py to assert this new behavior. There are no review comments, and I have no feedback to provide.