Update linter and formatter to match#60
Merged
sethvargo merged 10 commits intoFeb 28, 2020
Merged
Conversation
Sure, that'd be great. Thanks! |
14kb drop in compiled package
There was a bug in the current tests where, depending on execution order, the tool path would differ. That's because actions/toolcache reads the RUNNER_TOOL_CACHE and RUNNER_TEMP environment variables only once on initial import/require. So, depending on which test ran first, future tests might fail. This commit introduces a different way to create cache directories, caching the cached directory across tests (irony recognized). Alternative approaches included re-requiring the actions/toolcache package, but that added 3min to the total build.
|
Thanks for the contribution! One general note, using git mv is preferred over git rm and git add, as it preserves the history for the file. |
Contributor
Author
|
@craigdbarber ack, sorry |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match linter and esrules
Do you want me to also update husky in this PR?