Conversation
Closed
added 2 commits
June 10, 2021 17:29
Codecov Report
@@ Coverage Diff @@
## issue121 #117 +/- ##
==========================================
- Coverage 49.5% 49.4% -0.1%
==========================================
Files 39 39
Lines 2847 2855 +8
==========================================
+ Hits 1410 1412 +2
- Misses 1437 1443 +6
Continue to review full report at Codecov.
|
added 10 commits
June 11, 2021 15:50
taiya
commented
Jun 12, 2021
| yield self | ||
| finally: | ||
| return | ||
| return # TODO(klausg): deal with pylint warning |
Collaborator
Author
There was a problem hiding this comment.
Not sure what was the rationale behind this code fragment.
Pylint complaining profusely: return statement in finally block may swallow exception
Collaborator
Author
There was a problem hiding this comment.
I have disabled the warning, and left several TODO(klausg) for things I cannot resolve myself.
Collaborator
Author
|
@Qwlouse 🎉 🎉 🎉 (took me ~4 hours...) where these all work as advertised.
|
Qwlouse
approved these changes
Jun 14, 2021
taiya
pushed a commit
that referenced
this pull request
Aug 18, 2021
* google pylint configuration * pylint fixes * docstring objects * removed __all__ and compartimentalized pybullet & blender * pylint complaint fix * pylint tweaks assets * pylint traits.py * pylint klevr_uni.py * pylint datasets/klevr.py * pylint kubric/core/color.py * pybullet pylint * pylint kubric/utils.py * pylint kubric/renderer/blender.py * pylint kubric/renderer/blender_utils.py * pylint kubric/* * test.yml executes on ALL branches now * pylint.yml executes on ALL pull requests * test.yml: better workflow name * fixed last pylint error Co-authored-by: Klaus Greff <klausg@google.com>
taiya
pushed a commit
that referenced
this pull request
Aug 18, 2021
* google pylint configuration * pylint fixes * docstring objects * removed __all__ and compartimentalized pybullet & blender * pylint complaint fix * pylint tweaks assets * pylint traits.py * pylint klevr_uni.py * pylint datasets/klevr.py * pylint kubric/core/color.py * pybullet pylint * pylint kubric/utils.py * pylint kubric/renderer/blender.py * pylint kubric/renderer/blender_utils.py * pylint kubric/* * test.yml executes on ALL branches now * pylint.yml executes on ALL pull requests * test.yml: better workflow name * fixed last pylint error Co-authored-by: Klaus Greff <klausg@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.