Raise NotFittedError from TabFMRegressor.predict before fit#46
Merged
Merged
Conversation
TabFMRegressor.predict on an unfitted estimator raised AttributeError
('X_encoder_') instead of sklearn's NotFittedError. Add the
check_is_fitted call in _predict_internal that TabFMClassifier already
has in _predict_proba_internal.
fus3r
requested review from
abhidas,
erzel,
rajatsen91,
siriuz42,
tamannarayan and
weihaokong
as code owners
July 3, 2026 12:33
weihaokong
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
predicton an unfittedTabFMRegressorraisesAttributeError: 'TabFMRegressor' object has no attribute 'X_encoder_'instead of sklearn's standardNotFittedError. The classifier already callscheck_is_fittedin_predict_proba_internal; the regressor's_predict_internalwas missing it. This adds the same check plus a test covering both estimators.Repro on main:
Testing:
pytest tabfm/src/classifier_and_regressor_test.py tabfm/src/classifier_and_regressor_pytorch_test.pypasses (39 tests).