Use holdout set for learned parameters when using row subsampling. - #85
Open
tamannarayan wants to merge 4 commits into
Open
Use holdout set for learned parameters when using row subsampling.#85tamannarayan wants to merge 4 commits into
tamannarayan wants to merge 4 commits into
Conversation
… on when per-member row subsampling is active. Allows the joint setting of max_num_rows along with NNLS and/or calibration.
tamannarayan
requested review from
abhidas,
erzel,
rajatsen91,
siriuz42 and
weihaokong
as code owners
July 28, 2026 16:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt shared hold-out set to optimize NNLS and calibration parameters on when per-member row subsampling is active. Allows the joint setting of max_num_rows along with NNLS and/or calibration.
The hold-out set to be 5% of the total training dataset size or 1k rows, whichever is larger (with a total cap of 10k rows).