Skip to content

Update examples for deploying A2UI in Agent Engine#1208

Merged
yuantian-agentspace merged 13 commits into
mainfrom
gemini_enterprise
Apr 16, 2026
Merged

Update examples for deploying A2UI in Agent Engine#1208
yuantian-agentspace merged 13 commits into
mainfrom
gemini_enterprise

Conversation

@yuantian-agentspace
Copy link
Copy Markdown
Collaborator

Description

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Gemini Enterprise agent samples to use a2ui-agent-sdk v0.1.2, disables streaming, and refactors TaskUpdater logic. Feedback highlights critical issues including unresolved merge conflict markers in several files and the omission of contact_data.json from the deployment package, which will cause runtime errors. Additionally, it is recommended to restore dynamic UI extension activation and revert the use of print statements back to the logging module for better consistency and observability.

Comment on lines +29 to +33
<<<<<<< HEAD
"a2ui-agent-sdk>=0.1.1",
=======
"a2ui-agent-sdk",
>>>>>>> main
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Unresolved merge conflict markers found in the dependency list. This will break package installation and environment setup. Please resolve the conflict for the a2ui-agent-sdk version.

Comment on lines +33 to +37
<<<<<<< HEAD
from a2ui.a2a import try_activate_a2ui_extension
=======
from a2ui.a2a.extension import try_activate_a2ui_extension
>>>>>>> main
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Unresolved merge conflict markers detected in the imports. Please resolve the conflict and remove the markers to ensure the correct module is imported.

Comment thread samples/agent/adk/gemini_enterprise/agent_engine/agent_executor.py
Comment thread samples/agent/adk/gemini_enterprise/agent_engine/deploy.py
Comment thread samples/agent/adk/gemini_enterprise/agent_engine/agent.py
Copy link
Copy Markdown

@shavidissa shavidissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!LGTM

@yuantian-agentspace yuantian-agentspace merged commit 0948588 into main Apr 16, 2026
5 of 6 checks passed
@yuantian-agentspace yuantian-agentspace deleted the gemini_enterprise branch April 16, 2026 17:51
@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI Apr 16, 2026
new_task,
)
from a2a.utils.errors import ServerError
from a2ui.a2a.extension import try_activate_a2ui_extension
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package path was incorrect. #1234 fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants