Skip to content

fixed an issue with try_activate_a2ui_extension#1234

Merged
nan-yu merged 1 commit into
google:mainfrom
davxiao:main
Apr 20, 2026
Merged

fixed an issue with try_activate_a2ui_extension#1234
nan-yu merged 1 commit into
google:mainfrom
davxiao:main

Conversation

@davxiao
Copy link
Copy Markdown
Contributor

@davxiao davxiao commented Apr 19, 2026

Description

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.

Pre-launch Checklist

If you need help, consider asking for advice on the discussion board.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the import path for the try_activate_a2ui_extension function in agent_executor.py. A review comment suggests improving the code's adherence to PEP 8 by adding a blank line to separate library imports from local module imports.

)
from a2a.utils.errors import ServerError
from a2ui.a2a import try_activate_a2ui_extension
from a2ui.a2a.extension import try_activate_a2ui_extension
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

According to PEP 8, imports should be grouped in the following order: standard library imports, related third-party imports, and local application/library specific imports. Each group of imports should be separated by a blank line. Since a2ui is a library import and agent is a local module, there should be a blank line between them.

Suggested change
from a2ui.a2a.extension import try_activate_a2ui_extension
from a2ui.a2a.extension import try_activate_a2ui_extension
References
  1. PEP 8: Imports should be grouped and separated by blank lines. (link)

@jacobsimionato jacobsimionato requested a review from nan-yu April 20, 2026 05:21
@jacobsimionato
Copy link
Copy Markdown
Collaborator

Thank you for the fix, David! Can you take a look at this @nan-yu ? If this fix is valid, then maybe we need to make sure this code path is covered by CI, to prevent further regressions?

@nan-yu nan-yu merged commit d6419e4 into google:main Apr 20, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in A2UI Apr 20, 2026
@nan-yu
Copy link
Copy Markdown
Collaborator

nan-yu commented Apr 20, 2026

The issue was introduced in https://github.com/google/A2UI/pull/1208/changes#r3112783234.

Unfortunately, those sample agent executors don't have unit test coverage.

I filed #1241 to follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants