fixed an issue with try_activate_a2ui_extension#1234
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the import path for the try_activate_a2ui_extension function in agent_executor.py. A review comment suggests improving the code's adherence to PEP 8 by adding a blank line to separate library imports from local module imports.
| ) | ||
| from a2a.utils.errors import ServerError | ||
| from a2ui.a2a import try_activate_a2ui_extension | ||
| from a2ui.a2a.extension import try_activate_a2ui_extension |
There was a problem hiding this comment.
According to PEP 8, imports should be grouped in the following order: standard library imports, related third-party imports, and local application/library specific imports. Each group of imports should be separated by a blank line. Since a2ui is a library import and agent is a local module, there should be a blank line between them.
| from a2ui.a2a.extension import try_activate_a2ui_extension | |
| from a2ui.a2a.extension import try_activate_a2ui_extension | |
References
- PEP 8: Imports should be grouped and separated by blank lines. (link)
|
Thank you for the fix, David! Can you take a look at this @nan-yu ? If this fix is valid, then maybe we need to make sure this code path is covered by CI, to prevent further regressions? |
|
The issue was introduced in https://github.com/google/A2UI/pull/1208/changes#r3112783234. Unfortunately, those sample agent executors don't have unit test coverage. I filed #1241 to follow up. |
Description
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. For larger changes, raising an issue first helps reduce redundant work.
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.