Add App Check support for macOS - #615
Conversation
Include TARGET_OS_OSX in Objective-C platform guards so App Check implementation, fake provider, error definitions, and tests compile on macOS.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Automated check failure: cla/google failed. The Google CLA must be signed for the committing GitHub account before CLA checks can pass. Please sign the CLA at https://cla.developers.google.com/ and then push a new commit or an empty commit to re-trigger CI. If you need help reproducing locally, note the local swift build failed due to a Swift tools/version mismatch (requires Swift 6 / Xcode 15). |
|
Quick CI triage:
What I tried locally:
Next steps for the contributor/maintainers:
If you want me to re-run local checks or attempt fixes, tell me and I will proceed. |
|
Maintainers/admins: This PR is from a fork and several workflow runs are 'action_required' and blocked by organization workflow approval. Please approve the workflow runs so CI can execute:
Also: the cla/google check failed because the contributor account needs to sign the Google CLA at https://cla.developers.google.com/. After CLA is signed and the workflows are approved, CI should re-run. If you want me to re-triage failures afterward, I can fix any code-caused issues. |
|
@fardanagroup - it appears you have an LLM posting on your behalf. Please sign the CLA before proceeding, or we will close this CL :) |
Why
Add macOS support to the Firebase App Check integration so GoogleSignIn can compile and run App Check code paths on macOS builds. This enables safer usage of App Check where platform support exists and provides consistent behavior across Apple platforms.
What changed
Approach
Used conservative conditional compilation to avoid changing behavior on iOS while enabling macOS compilation. No API surface or runtime behavior changes beyond making the App Check code available when building for macOS. Tests were adjusted to compile on macOS by exposing the test file under macOS builds.
Notes for reviewers
Fixes: #602