Skip to content
This repository was archived by the owner on Aug 10, 2022. It is now read-only.

Fixes to /tools and /tools/chrome-devtools + three new tips #1510

Merged
merged 8 commits into from
Aug 14, 2015
Merged

Fixes to /tools and /tools/chrome-devtools + three new tips #1510

merged 8 commits into from
Aug 14, 2015

Conversation

@pbakaus
Copy link
Contributor

@pbakaus pbakaus commented Aug 7, 2015

This pull request includes:

  • SEO fixes to devtools and tools (i.e. better page titles)
  • Fix to counter minification mess with a h1 on the /tools page
  • Fix for the tips importer, tested with three new imported tips
  • Fixed path to feed in /tools
  • Fix in main navigation for DevTools

@pbakaus
Copy link
Contributor Author

pbakaus commented Aug 11, 2015

@arthurvr can you proofread the three new tips (markdown files)? They're imported from https://umaar.com/dev-tips/ and I fixed some styling but not much wording. They're pretty small, so should be a quick deal. Thanks!

@pbakaus
Copy link
Contributor Author

pbakaus commented Aug 11, 2015

@gauntface this pull request needs a lgtm from a writer first, then should be merged by you after a quick look, there are slight infra fixes in it.

@jpmedley
Copy link
Contributor

jpmedley commented Aug 11, 2015

I'm looking at it now.

jpmedley
jpmedley reviewed Aug 11, 2015
View reviewed changes
src/_langs/en/updates/2015-08-10-5-tricks-to-use-in-the-console-panel.markdown Outdated
Copy link
Contributor

@jpmedley jpmedley Aug 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'passed in' should be 'passed-in'.

Copy link
Contributor Author

@pbakaus pbakaus Aug 11, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@pbakaus pbakaus changed the title small fix that adds hard whitespace so the tools heading is not squis… Fixes to /tools and /tools/chrome-devtools + three new tips Aug 11, 2015
@umaar
Copy link
Contributor

umaar commented Aug 12, 2015

Those were a lot of changes 😦 - sorry about that, I should probably write to a stricter standard. @pbakaus feel free to @ mention me in similar proofreading PRs, the feedback here is very useful.

@pbakaus
Copy link
Contributor Author

pbakaus commented Aug 13, 2015

@umaar no worries! Will include you next time :)

@pbakaus
Copy link
Contributor Author

pbakaus commented Aug 13, 2015

@gauntface ping! PTAL.

@pbakaus
Copy link
Contributor Author

pbakaus commented Aug 13, 2015

@jpmedley could you give a "lgtm" (no merge yet)?

jpmedley added a commit that referenced this pull request Aug 14, 2015
@jpmedley
Merge pull request #1510 from google/tools_fixes
60597e0 
Fixes to /tools and /tools/chrome-devtools + three new tips
@jpmedley jpmedley merged commit 60597e0 into master Aug 14, 2015
@PaulKinlan PaulKinlan deleted the tools_fixes branch September 9, 2015 10:14
jpmedley added a commit that referenced this pull request Oct 29, 2015
@jpmedley
Merge pull request #1510 from google/tools_fixes
9fca13b 
Fixes to /tools and /tools/chrome-devtools + three new tips
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@gauntface gauntface

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pbakaus @jpmedley @umaar @gauntface @googlebot