fix(sessions): apply numRecentEvents and afterTimestamp together in InMemorySessionService#1373
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_952662247
branch
from
July 23, 2026 13:27
17d0e7c to
e3c3c50
Compare
…nMemorySessionService `getSession` applied `afterTimestamp` only when `numRecentEvents` was unset, so the two `GetSessionConfig` filters could not be combined. Apply `numRecentEvents` first, then `afterTimestamp`, so both compose. Mirrors Python and Go, which already apply both. PiperOrigin-RevId: 952725154
copybara-service
Bot
force-pushed
the
test_952662247
branch
from
July 23, 2026 13:32
e3c3c50 to
4d19f7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(sessions): apply numRecentEvents and afterTimestamp together in InMemorySessionService
getSessionappliedafterTimestamponly whennumRecentEventswas unset, so the twoGetSessionConfigfilters could not be combined. ApplynumRecentEventsfirst, thenafterTimestamp, so both compose. Mirrors Python and Go, which already apply both.