Thank you for providing this helpful sample. I noticed a minor inconsistency in how one of the referenced papers is identified.
🔴 Required Information
Describe the Bug:
The static_non_text_content sample incorrectly refers to arXiv paper 2403.05530 as the “Gemma Research Paper.”
The paper is actually Gemini 1.5: Unlocking multimodal understanding across millions of tokens of context.
The GCS and HTTPS references point to the same PDF, but they are labeled differently as “Gemma Research Paper” and “AI Research Paper.”
Steps to Reproduce:
- Open
contributing/samples/multimodal/static_non_text_content/agent.py.
- Find the GCS URI
gs://cloud-samples-data/generative-ai/pdf/2403.05530.pdf.
- Observe that its
display_name and related instructions identify it as a Gemma research paper.
- Look up arXiv ID
2403.05530 and confirm that it is the Gemini 1.5 paper.
- Observe similar “Gemma” references in
main.py and README.md.
Expected Behavior:
The paper should be consistently identified as the Gemini 1.5 research paper. For example:
Gemini 1.5 Research Paper (GCS)
Gemini 1.5 Research Paper (HTTPS)
Related prompts, instructions, and README descriptions should also refer to Gemini 1.5.
Observed Behavior:
The GCS reference is described as the “Gemma Research Paper,” while the HTTPS reference to the same PDF is described generically as an “AI Research Paper.”
Affected files include:
contributing/samples/multimodal/static_non_text_content/agent.py
contributing/samples/multimodal/static_non_text_content/main.py
contributing/samples/multimodal/static_non_text_content/README.md
Environment Details:
- ADK Library Version (pip show google-adk): N/A
- Desktop OS: N/A
- Python Version (python -V): N/A
Model Information:
- Are you using LiteLLM: N/A
- Which model is being used: N/A
Thank you for providing this helpful sample. I noticed a minor inconsistency in how one of the referenced papers is identified.
🔴 Required Information
Describe the Bug:
The
static_non_text_contentsample incorrectly refers to arXiv paper2403.05530as the “Gemma Research Paper.”The paper is actually Gemini 1.5: Unlocking multimodal understanding across millions of tokens of context.
The GCS and HTTPS references point to the same PDF, but they are labeled differently as “Gemma Research Paper” and “AI Research Paper.”
Steps to Reproduce:
contributing/samples/multimodal/static_non_text_content/agent.py.gs://cloud-samples-data/generative-ai/pdf/2403.05530.pdf.display_nameand related instructions identify it as a Gemma research paper.2403.05530and confirm that it is the Gemini 1.5 paper.main.pyandREADME.md.Expected Behavior:
The paper should be consistently identified as the Gemini 1.5 research paper. For example:
Gemini 1.5 Research Paper (GCS)Gemini 1.5 Research Paper (HTTPS)Related prompts, instructions, and README descriptions should also refer to Gemini 1.5.
Observed Behavior:
The GCS reference is described as the “Gemma Research Paper,” while the HTTPS reference to the same PDF is described generically as an “AI Research Paper.”
Affected files include:
contributing/samples/multimodal/static_non_text_content/agent.pycontributing/samples/multimodal/static_non_text_content/main.pycontributing/samples/multimodal/static_non_text_content/README.mdEnvironment Details:
Model Information: