Fix docs reference to database extra requirement#43
Closed
ShyamSathish005 wants to merge 2 commits into
Closed
Conversation
Fixes google#25 Update documentation and add 'database' extra requirement * **pyproject.toml** - Add a `database` extra requirement under `[project.optional-dependencies]` with `sqlalchemy>=2.0`. * **README.md** - Update the installation section to mention the `database` extra requirement for installing `DatabaseSessionService`.
pwwpche
reviewed
Apr 10, 2025
| "lxml>=5.3.0", # For load_web_page tool. | ||
| ] | ||
|
|
||
| database = [ |
Contributor
There was a problem hiding this comment.
sqlalchemy is already present in the dependencies list (see line 45).
Collaborator
|
The homepage readme is more for illustrative purpose so we want to keep it simple. For actual tutorials, users should follow our docs: https://google.github.io/adk-docs/get-started/quickstart/. |
tutumomo
pushed a commit
to tutumomo/adk-python
that referenced
this pull request
Apr 26, 2025
* docs: add demo video link * docs: use video tag to render video in readme file * Update to use hyperlink * Update README.md --------- Co-authored-by: kthota-g <kcthota@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25
Update documentation and add 'database' extra requirement
pyproject.toml
databaseextra requirement under[project.optional-dependencies]withsqlalchemy>=2.0.README.md
databaseextra requirement for installingDatabaseSessionService.