fix(deps): expand OpenTelemetry upper bound to <=1.43.0#6426
Open
Varshith-Kali wants to merge 1 commit into
Open
fix(deps): expand OpenTelemetry upper bound to <=1.43.0#6426Varshith-Kali wants to merge 1 commit into
Varshith-Kali wants to merge 1 commit into
Conversation
Expand the opentelemetry-api and opentelemetry-sdk upper bound from <=1.42.1 to <=1.43.0 so downstream projects (e.g. ZenML 0.96.2 which requires opentelemetry-sdk==1.43.0) can resolve dependencies without conflicts. The expansion is narrow (one release) and preserves the existing lower bound. ADK's full telemetry test suite passes with 1.43.0 — verified locally: 275 passed, 2 pre-existing Windows-only failures unrelated to this change (resource module / instrumentation platform check). Fixes google#6421 Drafted with AI assistance, reviewed and tested by me before submission.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6421
google-adk 2.3.0–2.5.0 constrain opentelemetry-api and opentelemetry-sdk to <=1.42.1. This prevents interoperability with projects that require opentelemetry-sdk==1.43.0 (e.g. ZenML 0.96.2 for FastAPI 0.138 support), leaving no overlapping version for dependency resolution.
This PR expands the upper bound from <=1.42.1 to <=1.43.0 — a narrow one-release bump that preserves the existing lower bound (>=1.39).
Changes
Why
The issue reporter (@dacongming0425) already validated that ADK 2.5.0 telemetry tests pass with OpenTelemetry 1.43.0:
A narrow <=1.43.0 expansion is preferable to removing the upper bound entirely because ADK uses unstable OpenTelemetry log APIs that may break across releases.
Testing
Ran the full telemetry test suite locally with opentelemetry-api==1.43.0 and opentelemetry-sdk==1.43.0 installed:
275 passed, 2 failed, 18 warnings in 34.82sThe 2 failures are pre-existing Windows platform issues unrelated to this change:
Both failures reproduce on the unmodified main branch on Windows.
Testing Plan
AI Assistance Disclosure
Drafted with AI assistance, reviewed and tested by me before submission.