fix: use Optional[List[str]] in cleanup_unused_files to fix automatic function calling parse error - #6517
Open
guptaishaan wants to merge 1 commit into
Open
fix: use Optional[List[str]] in cleanup_unused_files to fix automatic function calling parse error#6517guptaishaan wants to merge 1 commit into
guptaishaan wants to merge 1 commit into
Conversation
… function calling parse error The `cleanup_unused_files` tool function declared its optional list parameters using Signed-off-by: Ishaan <ishaangupta0408@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cleanup_unused_filestool function declared its optional list parameters usingPEP 604 union syntax (
list[str] | None), which the ADK automatic function callingparameter parser does not support, causing a
Failed to parse the parameter file_patterns: List[str] | None = Noneerror whenever the agent builder assistantwas used in
adk web.The fix replaces the two affected parameter annotations with the equivalent
Optional[List[str]]form (fromtyping), which the parser handles correctly.This matches the pattern already used in other built-in agent tools such as
search_adk_source.py.Fixes #3591.