kokoro: clarify that MSVC flows are MSVC 2019#1070
Merged
dneto0 merged 3 commits intogoogle:mainfrom Jan 6, 2025
Merged
Conversation
They are running MSVC, but the jobs and directories are mislabeled as MSVC 2017. Bug: crbug.com/385757633 (internal) Change-Id: I8bd757e6bc13e4e7f20bb3f4d4dc30236d585361
Collaborator
Author
|
This has to wait until a google-internal CL lands to change the targeted config file name. |
dj2
reviewed
Dec 23, 2024
Collaborator
dj2
left a comment
dj2
left a comment
There was a problem hiding this comment.
Should we delete the 2017 folders?
Change-Id: If24a688c7c565a03e3015722ee8fa110c208b907
Collaborator
Author
Yes. I accidentally left that out. :-) |
Pass the visual studio version to the windows build script Change-Id: I1cf21ed387a52f4a260211be9964d84dc446d2f4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are running MSVC, but the jobs and directories are mislabeled as MSVC 2017.
Bug: crbug.com/385757633 (internal)
Change-Id: I8bd757e6bc13e4e7f20bb3f4d4dc30236d585361