-
Notifications
You must be signed in to change notification settings - Fork 70
Adding shader long vector feature #1100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This looks good to me, need to see what the bots say. Is it possible to add an amber example script into the repo to show the functionality? |
|
Hi Dan, I prepared this pull request because I’m helping to get the new CTS tests for VK_EXT_shader_long_vector passing amber verification in our CI. I upcoming CTS tests there already is an amber file that Jeff Bolz @jeffbolznv wrote for testing purposes: Does that count as an example? or after adding each new feature to amber you'll also like to have some kind of internal sample? |
|
Having a small test file in the amber repo itself at least lets us know if we happen to break anything before it rolls into CTS, but I won't block this change on it. Once the bots are good, and you'll need to update on top of the change from yesterday, this should be good to go I think. |
Adds support for requesting the shader long vector to be used.
|
The failures seem like cmake failures with swiftshader? I wonder if one of the changed dependencies is causing cmake to work differently? |
|
Ok I think that updating swiftshader DEPS would do the trick |
|
Thanks a lot for the CL. I'm ignoring the NDK build, I think it needs some work to get running so merged as is. |
Adds support for requesting the shader long vector to be used
DEPS update to alight witch v1.4.337