Skip to content

Conversation

@pingpongcat
Copy link
Contributor

Adds support for requesting the shader long vector to be used
DEPS update to alight witch v1.4.337

@dj2
Copy link
Collaborator

dj2 commented Jan 19, 2026

This looks good to me, need to see what the bots say. Is it possible to add an amber example script into the repo to show the functionality?

@pingpongcat
Copy link
Contributor Author

Hi Dan, I prepared this pull request because I’m helping to get the new CTS tests for VK_EXT_shader_long_vector passing amber verification in our CI.

I upcoming CTS tests there already is an amber file that Jeff Bolz @jeffbolznv wrote for testing purposes:
(note: you need access to the Khronos repository)

https://gerrit.khronos.org/c/vk-gl-cts/+/18489/6/external/vulkancts/data/vulkan/amber/spirv_assembly/instruction/compute/vector_shuffle/long_vector_shuffle.amber

Does that count as an example? or after adding each new feature to amber you'll also like to have some kind of internal sample?

@dj2
Copy link
Collaborator

dj2 commented Jan 20, 2026

Having a small test file in the amber repo itself at least lets us know if we happen to break anything before it rolls into CTS, but I won't block this change on it. Once the bots are good, and you'll need to update on top of the change from yesterday, this should be good to go I think.

Adds support for requesting the shader long vector to be used.
@dj2
Copy link
Collaborator

dj2 commented Jan 20, 2026

The failures seem like cmake failures with swiftshader? I wonder if one of the changed dependencies is causing cmake to work differently?

@pingpongcat
Copy link
Contributor Author

Ok I think that updating swiftshader DEPS would do the trick

@dj2 dj2 added the kokoro:run label Jan 21, 2026
@dj2 dj2 merged commit 4e0fc42 into google:main Jan 21, 2026
12 of 13 checks passed
@dj2
Copy link
Collaborator

dj2 commented Jan 21, 2026

Thanks a lot for the CL. I'm ignoring the NDK build, I think it needs some work to get running so merged as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants