Replace non-vendor-boot unpack_bootimg.py invocations with a C++ implementation#2203
Merged
Databean merged 5 commits intogoogle:mainfrom Mar 2, 2026
Merged
Replace non-vendor-boot unpack_bootimg.py invocations with a C++ implementation#2203Databean merged 5 commits intogoogle:mainfrom
Databean merged 5 commits intogoogle:mainfrom
Conversation
It created files with no permissions. Bug: b/488486740
This supports creating a view of a `ReadWriteFilesystem` makes a subdirectory look like the root directory. Bug: b/488486740
Bug: b/488486740
This information is otherwise reported by unpack_bootimg.py Bug: b/488486740
The full extract is now only used for the gem5 flow. Otherwise the repacker only needs the kernel command line and the ramdisk. Bug: b/488486740
Member
Author
|
FYI @rmuthiah |
jemoreira
approved these changes
Mar 2, 2026
Member
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unpack_bootimg.pywas called to extract the kernel command line arguments and the ramdisk, unnecessarily extracting the kernel. The ramdisk in the original boot image seems to be empty anyway.It also required launching a new process and invoking the python interpreter.
Bug: b/488486740