Skip to content

Replace mkbootimg calls for boot images with a C++ implementation#2217

Merged
Databean merged 4 commits intogoogle:mainfrom
Databean:boot_image_builder
Mar 5, 2026
Merged

Replace mkbootimg calls for boot images with a C++ implementation#2217
Databean merged 4 commits intogoogle:mainfrom
Databean:boot_image_builder

Conversation

@Databean
Copy link
Copy Markdown
Member

@Databean Databean commented Mar 4, 2026

This saves using the IO of writing out intermediate files and reading them back in, and the small overhead of running the python interpreter. It also leads into better test coverage and building composite disks to represent boot images which skips the up-front IO entirely.

Bug: b/489209555

@Databean Databean requested a review from jemoreira March 4, 2026 08:03
Comment thread base/cvd/cuttlefish/io/concat.cc Outdated
@Databean Databean force-pushed the boot_image_builder branch from 685dff0 to 2ca304d Compare March 4, 2026 22:11
@Databean
Copy link
Copy Markdown
Member Author

Databean commented Mar 4, 2026

Thanks for reviewing!

@Databean Databean added this pull request to the merge queue Mar 4, 2026
@Databean Databean removed this pull request from the merge queue due to a manual request Mar 4, 2026
@Databean Databean added this pull request to the merge queue Mar 4, 2026
Merged via the queue into google:main with commit dea17f4 Mar 5, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants