Replace mkbootimg calls for boot images with a C++ implementation#2217
Merged
Databean merged 4 commits intogoogle:mainfrom Mar 5, 2026
Merged
Replace mkbootimg calls for boot images with a C++ implementation#2217Databean merged 4 commits intogoogle:mainfrom
Databean merged 4 commits intogoogle:mainfrom
Conversation
jemoreira
approved these changes
Mar 4, 2026
Bug: b/489209555
Bug: b/489209555
Bug: b/489209555
Bug: b/489209555
685dff0 to
2ca304d
Compare
Member
Author
|
Thanks for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This saves using the IO of writing out intermediate files and reading them back in, and the small overhead of running the python interpreter. It also leads into better test coverage and building composite disks to represent boot images which skips the up-front IO entirely.
Bug: b/489209555