Skip to content

Fail if new BOARD_BOOTCONFIG keys are found.#2358

Merged
ser-io merged 1 commit intogoogle:mainfrom
ser-io:allowed_builtin_configs
Apr 9, 2026
Merged

Fail if new BOARD_BOOTCONFIG keys are found.#2358
ser-io merged 1 commit intogoogle:mainfrom
ser-io:allowed_builtin_configs

Conversation

@ser-io
Copy link
Copy Markdown
Member

@ser-io ser-io commented Apr 8, 2026

Bug: b/495490297

@ser-io ser-io requested review from adelva1984 and jemoreira April 8, 2026 21:46
Comment thread base/cvd/cuttlefish/host/commands/assemble_cvd/bootconfig_args.cpp Outdated
@ser-io ser-io force-pushed the allowed_builtin_configs branch 2 times, most recently from d3e4565 to c160b11 Compare April 9, 2026 16:42
@ser-io ser-io changed the title Fail if new builtin bootconfig args is found. Fail if new BOARD_BOOTCONFIG keys are found. Apr 9, 2026
@ser-io ser-io force-pushed the allowed_builtin_configs branch from c160b11 to 2179d32 Compare April 9, 2026 17:05
@ser-io
Copy link
Copy Markdown
Member Author

ser-io commented Apr 9, 2026

Thanks for reviewing!

@ser-io ser-io enabled auto-merge April 9, 2026 17:08
@ser-io ser-io added this pull request to the merge queue Apr 9, 2026
@ser-io ser-io removed this pull request from the merge queue due to a manual request Apr 9, 2026
- Restrict the use of build system variable `BOARD_BOOTCONFIG`, new bootconfig args should be added to the `cvd` launcher.

- Created a legacy list of keys for supporting legacy builds.

Bug: b/495490297
@ser-io ser-io force-pushed the allowed_builtin_configs branch from 2179d32 to 13dae73 Compare April 9, 2026 18:50
@ser-io ser-io enabled auto-merge April 9, 2026 18:50
@ser-io ser-io added this pull request to the merge queue Apr 9, 2026
Merged via the queue into google:main with commit 44e80f3 Apr 9, 2026
50 of 51 checks passed
@ser-io ser-io deleted the allowed_builtin_configs branch April 10, 2026 18:24
sync-agent-neo Bot pushed a commit to aosp-mirror-neo/device_google_cuttlefish that referenced this pull request Apr 21, 2026
Fail if new `BOARD_BOOTCONFIG` keys are found.
- Restrict the use of build system variable `BOARD_BOOTCONFIG`, new bootconfig args should be added to the `cvd` launcher.

- Created a legacy list of keys for supporting legacy builds.

Bug: 495490297
Test: cvd create
Change-Id: I5dc5abc97d2f58dcd488978ea44361a3043f3350
sync-agent-neo Bot pushed a commit to aosp-mirror-neo/device_google_cuttlefish that referenced this pull request Apr 21, 2026
sync-agent-neo Bot pushed a commit to aosp-mirror-neo/device_google_cuttlefish that referenced this pull request Apr 21, 2026
This is an Android Culprit Assistant revert, created as part of a culprit search session (http://go/aca-get/1c79c45c-e7c8-4187-9f83-74958af8eb04). Please review this revert and approve if it looks good to you.

Bug: 502082415
Change-Id: Ib40cb66367ba0ec2efafa31f6d3163f5ae4e5b84
Signed-off-by: boq-android-culprit-assistant@system.gserviceaccount.com
Bug: 495490297
sync-agent-neo Bot pushed a commit to aosp-mirror-neo/device_google_cuttlefish that referenced this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants